Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for @homepage and upmix to @homepageURL for symmetry #174

Merged
merged 4 commits into from
Jun 17, 2014

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 16, 2014

  • Controller insertion for multiple values... this is useful since one homepage might be here on OUJS and another might be on GH or dev... nice to know
  • Upmix @homepage to @homepageURL for future support of @supportURL from Scriptish
  • Rewrite affected views/pages/scriptPage.html to accommodate list... original source was missing href attribute value.

Tested okay in dev environment here.

Martii added 2 commits June 15, 2014 22:39
* Controller insertion for multiple values... this is useful since one homepage might be here on OUJS and another might be on GH... nice to know
* Upmix `@homepage` to `@homepageURL` for future support of `@supportURL` from Scriptish
* Rewrite affected views/pages/scriptPage.html to accomodate list... original source was missing `href` attribute value.

Tested okay in dev environment [here](http://localhost:8080/scripts/marti/httplocalhost.localdomain/RFC_2606%C2%A73_-_license_and_licence_Unit_Test)
@Martii
Copy link
Member Author

Martii commented Jun 16, 2014

Squished down @contributors, while I'm at it, to look like discussion pages first and last comment... this should save some wasted screen real estate and fits in with the current theme layout.

* Change matching CSS to always be white with `.info-label a` and no text decoration.

Applies to OpenUserJS#174
@Martii
Copy link
Member Author

Martii commented Jun 16, 2014

Ready for eval, vote and with potential merge. Currently no references found to ./views/pages/scriptPage.html in fixes from #173 so we shouldn't bump into each other.

(Image removed)

sizzlemctwizzle added a commit that referenced this pull request Jun 17, 2014
Fix support for `@homepage` and upmix to `@homepageURL` for symmetry
@sizzlemctwizzle sizzlemctwizzle merged commit e9c8b8c into OpenUserJS:master Jun 17, 2014
@Martii Martii removed the sooner label Jun 18, 2014
@Martii Martii deleted the fixHomepageMeta branch June 19, 2014 08:26
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jun 19, 2014
…ation

**NOTE**: It appears that Zren is using `.meta` to be the actual metadata block items and so any manipulation of these should be stored elsewhere just in case `collaborators`, etc. is ever used/supported in a metadata block... doubt it will based off of Anthony's prior responses but does make the code simpler to read.

Applies to:
* OpenUserJS#174
* OpenUserJS#161
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jan 21, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

2 participants